fix: [CI-11840]: Added env variable to control the event of inbound w… #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/drone-server/config/config.go
Outdated
| @@ -443,6 +444,10 @@ type ( | |||
| ContentSecurityPolicy string `envconfig:"DRONE_HTTP_CONTENT_SECURITY_POLICY"` | |||
| ReferrerPolicy string `envconfig:"DRONE_HTTP_REFERRER_POLICY"` | |||
| } | |||
|
|
|||
| InboundWebhookEvents struct { | |||
There was a problem hiding this comment.
Nit: remove Events from InboundWebhookEvents
And rename Inbound -> Incoming
service/hook/hook.go
Outdated
| } | ||
|
|
||
| func (s *service) Create(ctx context.Context, user *core.User, repo *core.Repository) error { | ||
| err := s.renew.Renew(ctx, user, false) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var eventsMap map[string]bool | ||
| eventsMap = make(map[string]bool) |
There was a problem hiding this comment.
Nit: eventsMap := make(map[string]bool)
vistaarjuneja
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added the env var "DRONE_INCOMING_WEBHOOK_EVENTS" (of type list of string) to control the event in case of incoming webhook. If no such env variable is provided then it will fallback to default behaviour. Below are the test cases
Screen.Recording.2024-04-30.at.1.20.01.PM.mov
Screen.Recording.2024-04-30.at.1.23.45.PM.2.mov
Screen.Recording.2024-04-30.at.1.47.50.PM.mov
Screen.Recording.2024-04-30.at.1.53.22.PM.mov
Tested with few more combinations as well.