Fix for possible race for new block post consensus processing. #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR seems to break consensus, travis tests are not moving |
Frozen
force-pushed
the
fix/bingo-hooray-race
branch
from
aff96ee
to
cfc5bb2
Compare
sophoah
reviewed
May 28, 2024
|
could you explain why this PR may fix the possible race condition with the post consensus process ? |
It removes https://github.com/harmony-one/harmony/pull/4677/files#diff-255a5cdd5516e7293e60a47a92503360676ddffb7e48e505598a589753b568c2L672 which execution is not predictable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for possible race for new block post consensus processing.