Extract Subscription Settings from Storage Settings #5887
Merged
+727
−542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fil512
requested review from
tadgh,
AD1306,
jamesagnew and
JPercival
as code owners
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5887 +/- ##
============================================
+ Coverage 83.39% 83.45% +0.05%
- Complexity 26927 27234 +307
============================================
Files 1681 1697 +16
Lines 103965 105320 +1355
Branches 13189 13311 +122
============================================
+ Hits 86702 87893 +1191
- Misses 11613 11725 +112
- Partials 5650 5702 +52 ☔ View full report in Codecov by Sentry. |
fil512
changed the title
TipzCM
approved these changes
Jun 12, 2024
...hir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/config/BaseSubscriptionSettings.java
Outdated
Show resolved
Hide resolved
...hir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/config/BaseSubscriptionSettings.java
Outdated
Show resolved
Hide resolved
...hir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/config/BaseSubscriptionSettings.java
Outdated
Show resolved
Hide resolved
...est/java/ca/uhn/fhir/jpa/subscription/match/matcher/matching/DaoSubscriptionMatcherTest.java
Outdated
Show resolved
Hide resolved
tadgh
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract Subscription Settings from Storage Settings so they can be managed independently.