Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Subscription Settings from Storage Settings #5887

Merged
merged 26 commits into from
Jun 15, 2024

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Apr 30, 2024

Extract Subscription Settings from Storage Settings so they can be managed independently.

Copy link

github-actions bot commented Apr 30, 2024

Formatting check succeeded!

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (497b9f2) to head (ae334bb).
Report is 93 commits behind head on master.

Current head ae334bb differs from pull request most recent head 12a83eb

Please upload reports for the commit 12a83eb to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5887      +/-   ##
============================================
+ Coverage     83.39%   83.45%   +0.05%     
- Complexity    26927    27234     +307     
============================================
  Files          1681     1697      +16     
  Lines        103965   105320    +1355     
  Branches      13189    13311     +122     
============================================
+ Hits          86702    87893    +1191     
- Misses        11613    11725     +112     
- Partials       5650     5702      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fil512 fil512 changed the title Config cleanup Extract Subscription Settings from Storage Settings Jun 4, 2024
@fil512 fil512 enabled auto-merge (squash) June 14, 2024 23:21
Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the pass of the compile-against-cdr task

@fil512 fil512 merged commit 57d1815 into master Jun 15, 2024
64 checks passed
@fil512 fil512 deleted the ks-20240429-config-cleanup branch June 15, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants