Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes and adjustments for migrate to TS #8145

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

mrpiotr-dev
Copy link
Contributor

Context

This PR contains the necessary change for the first step of TS migration.
The following changes are included:

  • renamed src/*.js (excluding e2e tests) with src/*.ts
  • files with incorrect types have // @ts-nocheck comment
  • CI automation/ build/test/lint tools are adjusted
  • unit tests are now in the appropriate place (next to its source files in __tests__ directory) and are in TS
  • tsc generates temporary d.ts files into the publishing directory
  • .bundle is the new name for the publishing directory (following industry trends and good practices)

How has this been tested?

These changes need complex tests, especially for the final npm-ready package.

Types of changes

  • Dev-platform improvements

Related issue(s):

  1. Migration to TS #8144

Affected project(s):

  • handsontable

@mrpiotr-dev mrpiotr-dev self-assigned this Jun 1, 2021
@mrpiotr-dev mrpiotr-dev mentioned this pull request Jun 1, 2021
8 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2438abf:

Sandbox Source
vanilla-handsontable-pr Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants