Implement cached node elements for Walkontable renderers #6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements node elements cache for Walkontable renderers. This approach allows to cache particular cell element connected to the Walkontable source index without rendering needed when the value or content in that cell wasn't change. Currently, the NodesPool module, which is responsible for caching the nodes, keeps all of them in the memory - in the future it'll be tweaked. Generally, for more JS memory usage, we achieve faster rendering. This is one step further to make EcoRendering idea complete. Currently, there is missing a mechanism that tells Walkontable which cell should be re-rendered because some values, styles or cell meta properties changed. Issue: #5769
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05c9851:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This commit implements node elements cache for Walkontable renderers. This approach allows to cache particular cell element connected to the Walkontable source index without rendering needed when the value or content in that cell wasn't changed. Currently, the
NodesPoolmodule, which is responsible for caching the nodes, keeps all of them in the memory - in the future, it'll be tweaked.This PR is the basis for further development about implementing the EcoRendering idea.
How has this been tested?
Types of changes
Related issue(s):
Checklist: