Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pikaday and update numbro from prod dependencies #10950

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

budnix
Copy link
Member

@budnix budnix commented Apr 26, 2024

Context

The PR removes the pikaday (and its typings) from production dependencies and updates numbro to the latest version (2.5.0).

How has this been tested?

I tested the changes locally.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s):

  1. fixes Update production dependencies (remove Pikaday, bump Numbro, DOMPurify and momentjs) #10929
  2. Revert the braking changes from develop #10949

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Apr 26, 2024
@budnix budnix marked this pull request as ready for review April 26, 2024 08:24
Copy link

Launch the local version of documentation by running:

npm run docs:review bf9cc28e78adae6c5e8261a08bab99e5d67994d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant