Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for react-redux.md docs compilation #10832

Merged

Conversation

NOtherDev
Copy link

Context

[skip changelog]
Fix for documentation compilation error introduced in #10793.

How has this been tested?

N/A - docs change

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. React wrapper: Change the way editor might be passed to HotColumn and HotTable to use render props approach #10793

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@NOtherDev NOtherDev marked this pull request as ready for review February 28, 2024 12:07
@NOtherDev
Copy link
Author

@evanSe Docs in #10831 does not compile because of this overlooked issue. Let's merge in please 🙏

@NOtherDev NOtherDev marked this pull request as draft February 28, 2024 12:44
@NOtherDev NOtherDev marked this pull request as ready for review February 28, 2024 13:15
@NOtherDev NOtherDev self-assigned this Feb 28, 2024
@evanSe evanSe merged commit 1078e04 into handsontable:feature/improved-react Feb 28, 2024
17 of 18 checks passed
@NOtherDev NOtherDev deleted the fix/hoteditor-docs branch February 28, 2024 21:35
@NOtherDev
Copy link
Author

Thx for merging @evanSe. This PR lead me to one more thought - the issue here was that the custom editor component was used outside of the editor prop (it was both a renderer and an editor in this case). It was failing on property access on undefined context at useHotEditor. Shall we maybe check it gracefully and issue a warning if someone places custom editor outside of editor prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants