Update README.md's #10749
Closed
Update README.md's #10749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magierg
reviewed
Jan 25, 2024
| #### Using a package manager | ||
|
|
||
| Get Handsontable from [npm](https://www.npmjs.com/package/handsontable), [Yarn](https://yarnpkg.com/package/handsontable) or [NuGet](https://www.nuget.org/packages/Handsontable). | ||
| Get Handsontable from your package manager of choice |
There was a problem hiding this comment.
why are we removing those links?
There was a problem hiding this comment.
I definitely want to remove NuGet, and was thinking we shouldn't really be informing users what a package manager is.
There was a problem hiding this comment.
- It's a weird juxtaposition of the
NPMheadline and mentioning any "package manager of choice" - This kind of suggests we support every possible package manager, and I'm pretty sure it's not true (there's probably some obscure package manager created as I write this sentence...)
magierg
approved these changes
Jan 25, 2024
jansiegel
reviewed
Jan 25, 2024
| colHeaders: true | ||
| colHeaders: true, | ||
| height: 'auto', | ||
| autoWrapRow: true, |
There was a problem hiding this comment.
I know this is what the default setup should look like now, but mentioning
autoWrapRow: true,
autoWrapCol: true,
in every demo, even the simplest one, suggests that these options are somehow crucial to initializing Handsontable, and that's not true.
If we want them to be enabled by default, we should make them enabled by default.
There was a problem hiding this comment.
That is the plan, but we cannot implement it until next major release. For now, we will add it to everything.
budnix
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we aim to enhance the initial user experience when encountering our repository. The purpose of this pull request is to take a step towards achieving that goal.
The changes introduced in this pull request are as follows:
Changes
These modifications aim to enhance consistency in our documentation and streamline the user's journey by linking directly to our documentation, eliminating redundant information present in another README.MD.
[skip changelog]