Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Italian translation for new context menu labels #10117

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

imcatta
Copy link

@imcatta imcatta commented Nov 19, 2022

Context

New UI labels translations are needed #10112

How has this been tested?

No tests are needed for translations

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Call for translations: Copy with headers #10112
  2. Add it-IT language #5406

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@AMBudnik
Copy link
Contributor

AMBudnik commented Nov 21, 2022

Thank you very much for the contribution by updating the Italian translation! :)

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Nov 21, 2022

Hi @imcatta

Thank you for the translation. In the meantime, we've made some changes to the specification. The current version looks like this:

  • Copy with header
  • Copy with headers
  • Copy with group headers
  • Copy header only
  • Copy headers only

In cases where there is the singular and plural form, it should be done as an array, like here:

https://github.com/handsontable/handsontable/blob/feature/issue-2288/handsontable/src/i18n/languages/en-US.js#L52-L54

If you could update your PR, that would be great :)

@imcatta
Copy link
Author

imcatta commented Dec 3, 2022

Done :)

@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 5, 2022

Hi @imcatta

Just one more questions (cause group headers have 2 options, plural and singular) is Copy with group headers -> 'Copia con intestazioni complete'?

@imcatta
Copy link
Author

imcatta commented Dec 5, 2022

Yes, that's correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants