Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serbian translation for new feature #10115

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

ivkeapp
Copy link
Contributor

@ivkeapp ivkeapp commented Nov 18, 2022

Context

New feature translation to the Serbian language.

How has this been tested?

Still not tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@ivkeapp ivkeapp changed the title Adding translation for new feature Add translation for new feature Nov 18, 2022
@AMBudnik
Copy link
Contributor

Thank you very much for the help with the translations, @ivkeapp 🎖️

@ivkeapp
Copy link
Contributor Author

ivkeapp commented Nov 21, 2022

Thank you very much for the help with the translations, @ivkeapp 🎖️

No problem, anytime 🙂

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Nov 21, 2022

Hi @ivkeapp

Thank you for the translation. In the meantime, we've made some changes to the specification. The current version looks like this:

  • Copy with header
  • Copy with headers
  • Copy with group headers
  • Copy header only
  • Copy headers only

In cases where there is the singular and plural form, it should be done as an array, like here:

https://github.com/handsontable/handsontable/blob/feature/issue-2288/handsontable/src/i18n/languages/en-US.js#L52-L54

If you could update your PR, that would be great :)

@krzysztofspilka krzysztofspilka changed the title Add translation for new feature Add Serbian translation for new feature May 24, 2023
@adrianszymanski89
Copy link
Contributor

Hi @ivkeapp

Would it be possible for you to add the changes I mentioned here? #10115 (comment)

That would be really helpful for us and would let us finish this PR :)

@ivkeapp
Copy link
Contributor Author

ivkeapp commented May 25, 2023

Hi @ivkeapp

Would it be possible for you to add the changes I mentioned here? #10115 (comment)

That would be really helpful for us and would let us finish this PR :)

Hello, I have added plural translations for new feature

@adrianszymanski89
Copy link
Contributor

Hi @ivkeapp

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants