Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress and Rating columns should be editable in the main demo #9581

Open
krzysztofspilka opened this issue Jun 14, 2022 · 3 comments · May be fixed by #9935
Open

Progress and Rating columns should be editable in the main demo #9581

krzysztofspilka opened this issue Jun 14, 2022 · 3 comments · May be fixed by #9935
Labels
Docs: Tools Issues related to Handsontable's documentation tools (VuePress, deployment, scripts etc.)

Comments

@krzysztofspilka
Copy link
Member

Description

I would expect that cells in columns "Progress" and "Rating" are editable.

  • Progress: cell editor - numeric in the range 0-100. If beyond the range, set the edge value (minimum or maximum) and close the editor.
  • Rating: cell editor - numeric in the range 0-5. If beyond the range, set the edge value (minimum or maximum) and close the editor.

Screenshot 2022-06-14 at 15 49 23

Links

https://handsontable.com/docs/demo/
@krzysztofspilka krzysztofspilka added the Docs: Tools Issues related to Handsontable's documentation tools (VuePress, deployment, scripts etc.) label Jun 14, 2022
@aninde aninde mentioned this issue Aug 5, 2022
Closed
@krzysztofspilka krzysztofspilka added this to the 12.2 (September 2022) milestone Aug 18, 2022
@warpech
Copy link
Member

warpech commented Aug 30, 2022

As part of this issue:

  1. the data source should be changed from an array of arrays to an array of objects
  2. the source code should be improved to follow the current best practices for a given framework (if now something strikes as odd)

@warpech
Copy link
Member

warpech commented Aug 30, 2022

This should be done as 1 framework = 1 pull request, starting from React.

bulaj pushed a commit that referenced this issue Sep 21, 2022
Update react-scripts package (#9581)
c9b701b 
To prevent errors with development server.
bulaj pushed a commit that referenced this issue Sep 21, 2022
Change data structure (#9581)
1d67c9b
bulaj pushed a commit that referenced this issue Sep 21, 2022
Add editing for progress and rating columns in react demo (#9581)
ce66e96
@bulaj bulaj linked a pull request Sep 21, 2022 that will close this issue
Open
12 tasks
bulaj pushed a commit that referenced this issue Sep 22, 2022
Update docs to reflect test flow (#9581)
f4490ff
bulaj pushed a commit that referenced this issue Sep 28, 2022
Fix display of empty values in progress bar (#9581)
29c3849
bulaj pushed a commit that referenced this issue Sep 28, 2022
Block pasting non-numeric values in progress and rating columns (#9581)
b7ea8c3
bulaj pushed a commit that referenced this issue Sep 28, 2022
Block pasting non-numeric values in progress and rating columns (#9581)
1bb7697
@krzysztofspilka krzysztofspilka linked a pull request Oct 18, 2022 that will close this issue
Adds editing options for progress and rating columns in react demo. #9935
Open
12 tasks
@Serrrek89 Serrrek89 removed this from the 12.3.0 (December 2022) milestone Dec 14, 2022
@krzysztofspilka
Copy link
Member Author

PR to be finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs: Tools Issues related to Handsontable's documentation tools (VuePress, deployment, scripts etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds editing options for progress and rating columns in react demo. handsontable/handsontable
5 participants
@warpech @bulaj @jansiegel @krzysztofspilka @Serrrek89