Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Demo page in the docs (replace BigExample, fix iframe-related problems) #9209

Closed
krzysztofspilka opened this issue Feb 9, 2022 · 7 comments
Assignees
Labels
Docs: Content Issues related to Handsontable's documentation content Effort: Medium Impact: High Type: Improvement suggestion

Comments

@krzysztofspilka
Copy link
Member

Description

We restored the demo page at https://handsontable.com/docs/demo/ but we need to put finishing touches to it.

We can achieve that by:

  • Removing tabs (.row .tab)
  • Placing links to GitHub below the demo under the header "Find the code on GitHub"
  • Setting the background to transparent (.bigPreviewExample>div:not(.tab))

Before

Screen Shot 2022-02-09 at 16 45 39

After

Screen Shot 2022-02-09 at 16 45 22

@krzysztofspilka krzysztofspilka added Docs: Content Issues related to Handsontable's documentation content Type: Improvement suggestion labels Feb 9, 2022
@warpech
Copy link
Member

warpech commented Mar 18, 2022

In other words, remove <BigExample /> is favor of an iframe and a list of links. As an author of that component, I can do that.

@warpech warpech self-assigned this Mar 18, 2022
@warpech warpech changed the title Improve the Demo page in the docs Improve the Demo page in the docs (replace BigExample) Apr 1, 2022
@warpech
Copy link
Member

warpech commented May 25, 2022

There are more problems with the Demo in the Docs that need to be urgently fixed. Most of them were found in https://docs.google.com/spreadsheets/d/15q2Bv4UCIoXLktZDDqSTupTLSSO0BWvoxfJbeUbCauU/edit by @aninde and @krzysztofspilka:

  1. After filtering by column Rating (stars) and vertical scrolling there is some row-headers misalignment
    • @aninde please provide steps to reproduce.
  2. Autofill doesn't work
    • I can reproduce. I don't think iframe is to blame, because it works in other iframes
  3. This demo isn't exact copy of the https://handsontable.com/demo. Column order is different
  4. We missing checkbox in the rows headers.
    • I can reproduce, probably it was done by mistake
  5. Column menu, context menu don't fit in the iframe.
  6. Enable numeric editor in the Stars and Chart cells.
  7. Removal of the abnormally high row causes the grid to show the blank space above it instead of the remaining rows. Steps to reproduce: Edit a cell, insert multiple newline characters (ALT+ENTER), close the editor, delete the whole row.

I am removing it from the React docs project, because I think it can be fixed separately and quicker on develop.

warpech added a commit that referenced this issue May 25, 2022
as expressed in the requirement in #9209:

- Removing tabs (.row .tab)
- Placing links to GitHub below the demo under the header "Find the code on GitHub"
- Setting the background to transparent (.bigPreviewExample>div:not(.tab))
@aninde
Copy link
Contributor

aninde commented May 26, 2022

1. After filtering by column Rating (stars) and vertical scrolling there is some row-headers misalignment

Reproduction

  1. Filter by value 3 on column Rating
  2. Scroll horizontally to the right

Result:
Too much offset between cells and headers. The cells slide under the wtHolder headers
Kapture 2022-05-26 at 16 12 02

warpech added a commit that referenced this issue Jun 21, 2022
* remove BigExample in favor of a simpler iframe

as expressed in the requirement in #9209:

- Removing tabs (.row .tab)
- Placing links to GitHub below the demo under the header "Find the code on GitHub"
- Setting the background to transparent (.bigPreviewExample>div:not(.tab))

* change the words "Handsontable's source code" to "a demo of Handsontable"

because this is definitely not the source code of Handsontable, just a simple demo of its features

Co-authored-by: Jakub Wiśniewski <[email protected]>
@warpech
Copy link
Member

warpech commented Jun 21, 2022

The PR #9531 implements the problem expressed in the first message, but not the problems implemented in the later comments.

@warpech
Copy link
Member

warpech commented Jun 27, 2022

Another (maybe) problem:

8. When a filter is expanded, its position is not updated after scrolling:

Screen Shot 2022-06-28 at 12 40 35 AM

@warpech warpech changed the title Improve the Demo page in the docs (replace BigExample) Improve the Demo page in the docs (replace BigExample, fix iframe-related problems) Jul 1, 2022
@warpech
Copy link
Member

warpech commented Jul 11, 2022

I created a new issue to remove IFRAME from the Demo page: https://github.com/handsontable/dev-handsontable/issues/34

Other issues about bugs in Handsontable related to iframe (not to the Demo page) should be reported as a separate issues. Then this issue can be closed. @aninde can you do that?

@warpech warpech assigned aninde and unassigned warpech Jul 11, 2022
@aninde
Copy link
Contributor

aninde commented Aug 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs: Content Issues related to Handsontable's documentation content Effort: Medium Impact: High Type: Improvement suggestion
Projects
None yet
Development

No branches or pull requests

4 participants