Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: automatically approve comments or replies after admin replied it #5903

Merged
merged 1 commit into from May 20, 2024
Merged

refactor: automatically approve comments or replies after admin replied it #5903

merged 1 commit into from May 20, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 13, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.16.x

What this PR does / why we need it:

管理员回复评论或回复后自动通过审核

Which issue(s) this PR fixes:

Fixes #5870

Does this PR introduce a user-facing change?

管理员回复评论或回复后自动通过审核

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels May 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang May 13, 2024 07:32
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 13, 2024 07:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@guqing
Copy link
Member Author

guqing commented May 13, 2024

@ruibaby Console 回复评论后点击展开会因为乐观锁出现 500 错误，原因展开评论的回复会标记最后已读时间可能需要加上重试

@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 56.46%. Comparing base (5fdf6c0) to head (0635ed9).
Report is 175 commits behind head on main.

Files Patch % Lines
...run/halo/app/content/comment/ReplyServiceImpl.java 0.00% 61 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5903      +/-   ##
============================================
- Coverage     56.91%   56.46%   -0.45%     
- Complexity     3319     3462     +143     
============================================
  Files           587      612      +25     
  Lines         18968    20491    +1523     
  Branches       1401     1414      +13     
============================================
+ Hits          10795    11570     +775     
- Misses         7594     8340     +746     
- Partials        579      581       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JohnNiang
JohnNiang approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

application/src/main/java/run/halo/app/content/comment/ReplyServiceImpl.java Show resolved Hide resolved
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
ruibaby
ruibaby approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 94d625f into halo-dev:main May 20, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 20, 2024
@ruibaby ruibaby mentioned this pull request May 24, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request May 27, 2024
@ruibaby
feat: add retry feature for update last read time of comment (#5985)
6124ab9 
#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.16.x

#### What this PR does / why we need it:

为更新评论的最后读取时间添加重试机制。Ref #5903 (comment)

#### Does this PR introduce a user-facing change?

```release-note
None 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

未审核通过的评论管理员可以回复
3 participants
@guqing @JohnNiang @ruibaby