Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support view diffs between post content versions #5892

Closed
wants to merge 1 commit into from

Conversation

guqing
Copy link
Member

@guqing guqing commented May 11, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.16.x

What this PR does / why we need it:

支持查看文章内容版本间的差异比较功能

Which issue(s) this PR fixes:

Fixes #5849

Does this PR introduce a user-facing change?

支持查看文章内容版本间的差异比较功能

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG May 11, 2024 06:01
Copy link

f2c-ci-robot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 53.48837% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 56.51%. Comparing base (5fdf6c0) to head (a1ff7d7).
Report is 162 commits behind head on main.

Files Patch % Lines
...a/run/halo/app/content/AbstractContentService.java 22.22% 20 Missing and 1 partial ⚠️
...ava/run/halo/app/content/impl/PostServiceImpl.java 0.00% 10 Missing ⚠️
...halo/app/core/extension/endpoint/PostEndpoint.java 71.42% 8 Missing ⚠️
...src/main/java/run/halo/app/content/PatchUtils.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5892      +/-   ##
============================================
- Coverage     56.91%   56.51%   -0.41%     
- Complexity     3319     3473     +154     
============================================
  Files           587      612      +25     
  Lines         18968    20559    +1591     
  Branches       1401     1422      +21     
============================================
+ Hits          10795    11618     +823     
- Misses         7594     8359     +765     
- Partials        579      582       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feature/5849 branch 2 times, most recently from 4450697 to 400881b Compare May 11, 2024 06:46
Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@guqing
Copy link
Member Author

guqing commented May 13, 2024

尝试了一下,无法在后端实现此功能,可能在前端实现更合适,将 html 内容转为 Dom 树比较节点之后添加 class 属性,因此我将关闭此 PR

@guqing guqing closed this May 13, 2024
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章快照增强 快照之间可进行内容的比较
2 participants