Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.15] Fix the problem of not being able to initialize preset plugins #5883

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #5874

/assign JohnNiang

解决初始化时无法正常启用插件的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen May 10, 2024 05:47
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 25 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-2.15@98a4b12). Click here to learn what that means.

Files Patch % Lines
...rc/main/java/run/halo/app/plugin/SpringPlugin.java 0.00% 19 Missing ⚠️
...pp/core/extension/reconciler/PluginReconciler.java 50.00% 2 Missing and 2 partials ⚠️
...lo/app/core/extension/endpoint/PluginEndpoint.java 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.15    #5883   +/-   ##
===============================================
  Coverage                ?   56.51%           
  Complexity              ?     3462           
===============================================
  Files                   ?      612           
  Lines                   ?    20473           
  Branches                ?     1413           
===============================================
  Hits                    ?    11570           
  Misses                  ?     8322           
  Partials                ?      581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9a4c41a into halo-dev:release-2.15 May 10, 2024
8 checks passed
@JohnNiang JohnNiang modified the milestones: 2.15.x, 2.15.2 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants