New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: perf: lock the scroll position of the body when the Modal component is opened #3818
WIP: perf: lock the scroll position of the body when the Modal component is opened #3818
Conversation
…s opened Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3818 +/- ##
=========================================
Coverage 57.07% 57.07%
Complexity 3329 3329
=========================================
Files 587 587
Lines 18956 18956
Branches 1402 1402
=========================================
Hits 10820 10820
Misses 7558 7558
Partials 578 578 ☔ View full report in Codecov by Sentry. |
/hold 修改之后会和之前引入的 overlayscrollbars 有冲突,暂时 hold。 |
…ll-when-modal-is-active
…ll-when-modal-is-active
…ll-when-modal-is-active
…ll-when-modal-is-active
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ping @ruibaby |
暂时先不改了,因为 body 元素用了 overlayscrollbars,会有兼容问题,后续可能会考虑移除。 /close |
@ruibaby: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind improvement
/area console
/milestone 2.5.x
What this PR does / why we need it:
当有任意弹框出现时,自动锁定 body 元素的滚动位置。
Which issue(s) this PR fixes:
Fixes #3817
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?