This repository has been archived by the owner on May 22, 2024. It is now read-only.
Sourcery refactored main branch #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if has_frame: | ||
| return frame | ||
| return None | ||
| return frame if has_frame else None |
There was a problem hiding this comment.
Function get_video_frame refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if platform.system().lower() == 'darwin': | ||
| return 4 | ||
| return 16 | ||
| return 4 if platform.system().lower() == 'darwin' else 16 |
There was a problem hiding this comment.
Function suggest_max_memory refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-92
to
+90
| if 'ROCMExecutionProvider' in roop.globals.execution_providers: | ||
| return 1 | ||
| return 8 | ||
| return 1 if 'ROCMExecutionProvider' in roop.globals.execution_providers else 8 |
There was a problem hiding this comment.
Function suggest_execution_threads refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| faces = get_many_faces(frame) | ||
| if faces: | ||
| if faces := get_many_faces(frame): |
There was a problem hiding this comment.
Function get_one_face refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-24
to
+32
| commands = ['ffmpeg', '-hide_banner', '-hwaccel', 'auto', '-loglevel', roop.globals.log_level] | ||
| commands.extend(args) | ||
| commands = [ | ||
| 'ffmpeg', | ||
| '-hide_banner', | ||
| '-hwaccel', | ||
| 'auto', | ||
| '-loglevel', | ||
| roop.globals.log_level, | ||
| *args, | ||
| ] |
There was a problem hiding this comment.
Function run_ffmpeg refactored with the following changes:
- Merge extend into list declaration (
merge-list-extend)
Comment on lines
-84
to
+93
| return os.path.join(output_path, source_name + '-' + target_name + target_extension) | ||
| return os.path.join( | ||
| output_path, f'{source_name}-{target_name}{target_extension}' | ||
| ) |
There was a problem hiding this comment.
Function normalize_output_path refactored with the following changes:
- Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation)
| queues = [] | ||
| for _ in range(queue_per_future): | ||
| if not queue.empty(): | ||
| queues.append(queue.get()) | ||
| return queues | ||
| return [queue.get() for _ in range(queue_per_future) if not queue.empty()] |
There was a problem hiding this comment.
Function pick_queue refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| many_faces = get_many_faces(temp_frame) | ||
| if many_faces: | ||
| if many_faces := get_many_faces(temp_frame): |
There was a problem hiding this comment.
Function process_frame refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-59
to
+63
| many_faces = get_many_faces(temp_frame) | ||
| if many_faces: | ||
| if many_faces := get_many_faces(temp_frame): | ||
| for target_face in many_faces: | ||
| temp_frame = swap_face(source_face, target_face, temp_frame) | ||
| else: | ||
| target_face = get_one_face(temp_frame) | ||
| if target_face: | ||
| temp_frame = swap_face(source_face, target_face, temp_frame) | ||
| elif target_face := get_one_face(temp_frame): | ||
| temp_frame = swap_face(source_face, target_face, temp_frame) |
There was a problem hiding this comment.
Function process_frame refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif) - Use named expression to simplify assignment and conditional [×2] (
use-named-expression)
sourcery-ai
bot
force-pushed
the
sourcery/main
branch
from
4bef5a7
to
65859df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!