Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worked on adding githandle for Dr. Stephen M. Hubbard #6856

Closed

Conversation

deepak-getpu
Copy link
Member

@deepak-getpu deepak-getpu commented May 15, 2024

Fixes #6856

What changes did you make?

  • Added GitHub handle for Dr. Stephen M. Hubbard

Why did you make the changes (we will use this info to test)?

  • Changed as instructed in the issue

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board May 15, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b deepak-getpu-update-givelink-2009 gh-pages
git pull https://github.com/deepak-getpu/website.git update-givelink-2009

@roslynwythe
Copy link
Member

@deepak-getpu Please link this PR to an issue by replacing "replace_this_text_with_the_issue_number" with the issue number, and complete the remaining fields. Thank you

@ajb176 ajb176 self-requested a review May 15, 2024 12:38
Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepak-getpu

  • worked on adding githandle for Dr. Stephen M. Hubbard #6856 is the issue number of the pull request itself. What you need to link is the actual number of the issue you were assigned to.

  • You should remove the placeholder image links and the details tabs if you're not using them, and just write 'No visual changes to the website' if after testing in docker you don't see any changes.

  • In the 'Why did you make these changes' section, you should write what the issue means to solve. You can generally find this information in the linked issue.

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-pending-approval (Automated Column, do not place items here manually) May 15, 2024
@LRenDO
Copy link
Member

LRenDO commented May 15, 2024

Hi @deepak-getpu! Thanks for working on this issue! In addition to the changes @ajb176 requested, also make sure you add the same labels on this pull request as on the original issue. (This usually this happens automatically, but sometimes it doesn't work. It generally fails when the issue number isn't added at the time the PR was created.) Please also remove any unused bullet points from the original PR comment.

@deepak-getpu deepak-getpu self-assigned this May 16, 2024
@t-will-gillis t-will-gillis self-requested a review May 16, 2024 19:52
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepak-getpu Great job on your first issue! Some notes:

  • As @ajb176 notes: for "Fixes" use the number of the issue you have worked on, in your case replace the 6856 with 6718.
  • For the next time (not now)- when you name your branch, use the number of the original issue (that is, title it update-givelink-6718 instead)
  • On issue 6718, remember to check the "Action Items" that you completed
  • Also as Ajay notes, for "Why did you make the changes..." this is meant to be the reason from the original issue, in this case the reason could be something like "To reduce redundancy in the project files"
  • As @LRenDO notes: you can delete the empty lines under "What changes'' and "Why did you make ..."
  • And as Ajay notes, you can delete everything under "Screenshots of Proposed Changes..." and replace with "No visual changes"
  • You don't need to assign yourself to the PR...
  • Otherwise, your code edits are clean and correct.

This is looking good and you are almost there! Thanks for working on this issue

@deepak-getpu
Copy link
Member Author

deepak-getpu commented May 21, 2024

I was trying to do corrections by 1) re-adding in git, 2) commit 3)push in the new branch 4)running docker. However, I could not pull the request as indicated or demonstrated in the pre-boarding checklist documents. I am struggling to find a page similar to the one shown in the document for git pull. Any help and guidance on this would be appreciated.

@t-will-gillis
Copy link
Member

Hi @deepak-getpu:

I was trying to do corrections by 10 re-adding in git, 2) commit 3)push in the new branch 4)running docker. However, I could not pull the request as indicated or demonstrated in the pre-boarding checklist documents. I am struggling to find a page similar to the one shown in the document for git pull. Any help and guidance on this would be appreciated.

It seems like there was a miscommunication. The changes that the reviewers were asking for did not involve Git or Docker.

Any of us will be happy to help you- I am happy to help you with this if we can set up a specific time. You can also bring your questions to one of the meetings. Let us know.

@deepak-getpu
Copy link
Member Author

deepak-getpu commented May 21, 2024 via email

@deepak-getpu
Copy link
Member Author

Closing this pull request, replaced by #6886.

@HackforLABot HackforLABot removed this from test-pending-approval (Automated Column, do not place items here manually) in Project Board May 22, 2024
@deepak-getpu deepak-getpu deleted the update-givelink-2009 branch May 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants