Implement /api/feedbacks web api test and validation (#1749)

server/__tests__/feedback.test.js

@@ -0,0 +1,87 @@
+const request = require("supertest");
+const sgMail = require("@sendgrid/mail");
+const {
+ setupServer,
+ teardownServer
+} = require("../_jest-setup_/utils/server-setup");
+
+let server;
+
+beforeAll(async () => {
+ server = await setupServer();
+});
+
+afterAll(async () => {
+ await teardownServer();
+});
+
+describe("Feedback API endpoints for end user accounts", () => {
+ let originalSendgrid = sgMail.send;
+
+ beforeAll(async () => {
+ sgMail.send = jest.fn(async () => {
+ return { statusCode: 202 };
+ });
+ });
+
+ afterAll(async () => {
+ // cleanup state
+ sgMail.send = originalSendgrid;
+ });
+
+ // POST "/feedbacks" with a valid request body
+ it("should post feedback", async () => {
+ const res = await request(server)
+ .post("/api/feedbacks")
+ .send({
+ name: "John Darragh",
+ email: "[email protected]",
+ forwardToWebTeam: true,
+ comment: "This is a test comment.",
+ selectedProjects: [254]
+ });
+ expect(res.statusCode).toEqual(201);
+ });
+
+ // POST "/feedbacks" with a valid request body
+ it("should post feedback", async () => {
+ const res = await request(server)
+ .post("/api/feedbacks")
+ .send({
+ name: "John Darragh",
+ email: "[email protected]",
+ forwardToWebTeam: true,
+ comment: "This is a test comment.",
+ selectedProjects: [254]
+ });
+ expect(res.statusCode).toEqual(201);
+ });
+
+ // POST "/feedbacks" with empty comment
+ it("should not post feedback without comment", async () => {
+ const res = await request(server)
+ .post("/api/feedbacks")
+ .send({
+ name: "John Darragh",
+ email: "[email protected]",
+ forwardToWebTeam: true,
+ comment: "",
+ selectedProjects: [254]
+ });
+ expect(res.statusCode).toEqual(400);
+ });
+
+ // POST "/feedbacks" with empty name
+ it("should not post feedback without name", async () => {
+ const res = await request(server)
+ .post("/api/feedbacks")
+ .send({
+ name: "",
+ email: "[email protected]",
+ forwardToWebTeam: true,
+ comment: "This is a test comment",
+ selectedProjects: [254]
+ });
+ expect(res.statusCode).toEqual(400);
+ });
+});

server/app/controllers/feedback.controller.js

@@ -1,4 +1,9 @@
 const feedbackService = require("../services/feedback.service");
+const {
+ validate,
+ validationErrorMiddleware
+} = require("../../middleware/validate");
+const feedbackPostSchema = require("../schemas/feedback.post");
 
 const post = async (req, res) => {
  try {
@@ -11,5 +16,9 @@ const post = async (req, res) => {
 };
 
 module.exports = {
- post
+ post: [
+ validate({ body: feedbackPostSchema }),
+ post,
+ validationErrorMiddleware
+ ]
 };

server/app/schemas/feedback.post.js

@@ -0,0 +1,25 @@
+module.exports = {
+ type: "object",
+ required: ["name", "email", "forwardToWebTeam", "comment"],
+ properties: {
+ email: {
+ type: "string",
+ minLength: 3,
+ pattern: "\\S+@\\S+"
+ },
+ name: {
+ type: "string",
+ minLength: 1
+ },
+ comment: {
+ type: "string",
+ minLength: 1
+ },
+ forwardToWebTeam: {
+ type: "boolean"
+ },
+ selectedProjects: {
+ type: "array"
+ }
+ }
+};