Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console logs for pin loads 1719 #1735

Merged
merged 5 commits into from
May 24, 2024

Conversation

bphan002
Copy link
Member

@bphan002 bphan002 commented May 22, 2024

Fixes #1719

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved
  1. Start time is defined when a query is made to the database
  2. End time is defined when the map is finished loading
  3. Test case: Although this is not extremely accurate, I started a stopwatch when I selected a new date range that is going back previous years. This is done because a new SQL query is needed if going back previous years. It seems to be fairly close, but may take 1-2 seconds more after pins have fully loaded.

Changes

  • Added the pin loading time in the console.log
Screenshot 2024-05-22 at 3 56 48 PM

components/Map/index.js Outdated Show resolved Hide resolved
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, approved

@bphan002 bphan002 merged commit 564aac7 into hackforla:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Console logs to display when all Pins have loaded
2 participants