Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enter handler for the textbox #407

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add enter handler for the textbox #407

wants to merge 4 commits into from

Commits on Dec 18, 2020

  1. Add enter handler for textbox 

    Fixes: #372
    @VijithaEkanayake
    VijithaEkanayake committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    5c08d95 View commit details
    Browse the repository at this point in the history

  2. Update ui/src/textbox.test.tsx 

    Co-authored-by: mturoci <[email protected]>
    @VijithaEkanayake @mturoci
    VijithaEkanayake and mturoci committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    0b50eb3 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: mturoci <[email protected]>
    @VijithaEkanayake @mturoci
    VijithaEkanayake and mturoci committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6737d9f View commit details
    Browse the repository at this point in the history

  4. Introduce submit attribute to textbox 

    The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
    @VijithaEkanayake
    VijithaEkanayake committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    54ea7d5 View commit details
    Browse the repository at this point in the history