new gwizard module: servlets #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2015 19:08
Guice-ified the dropwizard-servlets package. Added some helper servlet modules to get them started. Bumped the javacTask to 1.8 for source/target.
Moved gwizard-servlet classes under org.gwizard.servlets Added gwizard-servlet tests
|
I've added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I've Guice-ified (GWizardified) the dropwizard's metrics-servlets package.
This brings in that nice AdminServlet functionality of being able to access your metrics, thread dumps, ping & health checks all within GWizard/Guice's warm embrace.
This is a sample PR. It is missing tests, however if you guys like the PR I can move over a lot of the tests from the metrics-servlets package. I saw in the google-group that at the moment, GWizard has been handed-off, so I am seeing if contributions are still being taken before finishing the PR.
Anyways please give me feedback.
Cheers.