Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Executing script after tunnel up #108

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

jaype87
Copy link

@jaype87 jaype87 commented Dec 17, 2021

Resolves #88

@guillaumedsde
Copy link
Owner

thanks for the contribution, I'll look this over after the holidays

Copy link
Owner

@guillaumedsde guillaumedsde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I've added a couple of minor suggestions

Some of these points will be made clearer for future contributors once I've added a proper CI to this project (curently the CI runs on gitlab its not ideal)

rootfs/usr/sbin/tunnelUp.sh Show resolved Hide resolved
rootfs/usr/sbin/tunnelUp.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelDown.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelUp.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelDown.sh Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
@jaype87
Copy link
Author

jaype87 commented Jan 10, 2022

Made some further changes to use environment variables instead of hardcoded paths.

@guillaumedsde guillaumedsde changed the base branch from master to development March 8, 2022 20:24
@jaype87
Copy link
Author

jaype87 commented May 6, 2022

@guillaumedsde Hey, GitHub still shows as chages requested for me, but I cannot find what exactly it refers to. Can you have another look from your end?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] [enhancement] - Executing script after tunnel up
2 participants