Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2432. Implements Dim.Auto for Content including subviews. #3451

Closed
wants to merge 4 commits into from

Conversation

tig
Copy link
Collaborator

@tig tig commented May 7, 2024

DimAutoStyle.Text is now complete and merged in #3416.

Fixes

Proposed Changes/Todos

  • Fully implement/test DimAutoStyle.Content
  • Implemement Dim.AutoSize (max: dim)
  • Use Dialog and MessageBox as test cases - This will require moving the dialog buttons to Padding as adornments.
  • Dive deep into all other PosDim objects and get clarity on behavior relative to Dim.Auto - Improve unit tests to validate
    • Dim.Absolute
    • Dim.Auto
    • Dim.Fill
    • Dim.Function
    • Dim.Width/Height
    • Pos.Absolute/At
    • Pos.AnchorEnd
    • Pos.Function
    • Pos.Anchor
    • Pos.Percent
    • Pos.Center
    • Pos.X/Y etc...

@tig
Copy link
Collaborator Author

tig commented May 17, 2024

Abandoning this PR. I'll create a new Issue and PR to finalize DimAutoStyle.Content after #3480 is merged. It makes a bunch of progress on this.

@tig tig closed this May 17, 2024
tig added a commit to tig/Terminal.Gui that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant