Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential github action smells #3449

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+5 −2
Open

Fix potential github action smells #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d81513
Fix gha smells:
ceddy4395 May 5, 2024
eae4ca9
Merge branch 'develop' into fix-gha-smells
tig May 30, 2024
2f380ea
Merge branch 'develop' into fix-gha-smells
tig Jun 9, 2024
391f744
Merge branch 'develop' into fix-gha-smells
tig Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/api-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
# only publish v2 (main or develop); v2 is published via the Terminal.GuiV2Docs repo
tig marked this conversation as resolved.
Show resolved Hide resolved
branches: [main, develop]
paths:
- docfx/**

permissions:
id-token: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:

jobs:
CodeQL-Build:

if: github.repository == 'gui-cs/Terminal.Gui'|| github.event_name == 'schedule'
runs-on: ubuntu-latest

steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
# Consider using larger runners for possible analysis time improvements.
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could clean this up, too, if we use an actual matrix.

And the default comments from the template are not relevant for us, so they could go away.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually... This is codeQL scanning and we do not have OS-specific dependencies.

We could do it on just one runner for this workflow unless anyone has any thoughts otherwise.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what runner would in that case take your preference? The Ubuntu one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well be that one. Likely to have the lowest total running time cost.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes clear!

timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }}
if: github.repository == 'gui-cs/Terminal.Gui'|| github.event_name == 'schedule'
tig marked this conversation as resolved.
Show resolved Hide resolved
permissions:
actions: read
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dotnet-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest

timeout-minutes: 10
steps:
- uses: actions/checkout@v4

Expand Down