Fixes #3407. Border Subviews
#3409
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o v2_3269_Bounds-ContentArea
…o v2_3269_Bounds-ContentArea
Updated several classes to improve viewport and content size handling. Added `SetFrame` method to `View` class in `ViewLayout.cs` and replaced direct `_frame` property setting. Updated `OnLayoutStarted` and `OnLayoutComplete` methods to take `ContentSize` instead of `oldViewport`. Added `ViewportChanged` event and `OnViewportChanged` method to `View` class in `ViewContent.cs`. Updated `DrawEventArgs` and `LayoutEventArgs` classes in `ViewEventArgs.cs` to include new and old viewport properties and removed `Rectangle` property. Updated `OnDrawContentComplete` method in `ViewDrawing.cs` to take `DrawEventArgs` instead of `Rectangle`. Updated `SetViewport` method in `ViewContent.cs` to trigger `OnViewportChanged` event. Added check in `ListView.cs` for view initialization before setting `ContentSize` and `Viewport`. Updated `FileDialog` class in `FileDialog.cs` to use `NewViewport.Width` instead of `e.Rectangle.Width`. Updated `ViewEventArgs` class in `ViewEventArgs.cs` to include a `view` parameter in its constructor.
Fixed ContentSize < 0 issue.
Updated the versions of various packages across four projects. In `ReactiveExample.csproj`, the `ReactiveUI` package was updated. In `Terminal.Gui.csproj`, the `System.IO.Abstractions` and `System.Text.Json` packages were updated. In `UICatalog.csproj`, the `Microsoft.VisualStudio.Azure.Containers.Tools.Targets`, `SixLabors.ImageSharp`, and `CsvHelper` packages were updated. In `UnitTests.csproj`, the `ReportGenerator`, `TestableIO.System.IO.Abstractions.TestingHelpers`, `xunit`, `xunit.runner.visualstudio`, and `coverlet.collector` packages were updated.
Fixed GetFocusColor to not show focus if nothing else can be foucused
|
|
|
TextField is drawing over the Border. Clipping problem? |
Please don't look at this yet. It is almost completely broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Borderto use subviews for title, lines, and close button #3407Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)