Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3312. Mouse API makes it way too hard to track button pressed. #3393

Open
wants to merge 10 commits into
base: v2_develop
Choose a base branch
from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Apr 9, 2024

Fixes

Proposed Changes/Todos

  • Add mouse clicked logic for only to raise on the same view that pressed it
  • If a mouse button was pressed and grabbed the mouse, the OnMouseEnter isn't ran. Now it run
  • Created the ProcessMouseEvent method allowing reuse the code
  • Add unit test
  • Add hot color for highlight
  • Some formatting

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not had a chance to fully review this, nor run it to see how it works. So I can't comment on whether it works.

But i do not think it actually makes tracking button presses easier, and I do not like aspects of the design. I've commented on those in my code review.

Terminal.Gui/Application.cs Show resolved Hide resolved
Terminal.Gui/Application.cs Show resolved Hide resolved
Terminal.Gui/Input/Mouse.cs Show resolved Hide resolved
@BDisp BDisp marked this pull request as draft May 2, 2024 11:02
@BDisp BDisp marked this pull request as ready for review May 2, 2024 14:20
Terminal.Gui/Application.cs Show resolved Hide resolved
Terminal.Gui/Application.cs Show resolved Hide resolved
Terminal.Gui/Application.cs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants