New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2114. 3D Effect #3376
Draft
tig
wants to merge
196
commits into
gui-cs:v2_develop
Choose a base branch
from
tig:v2_2144-3D-effect
base: v2_develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fixes #2114. 3D Effect #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Button sets true in cases where it makes sense. This mostly works. Needs more work.
…d via Config Manager. The UI Catalog theme sets both to true. AdornmentsEditor now has a Shadow checkbox
Added [GenerateEnumExtensionMethods] to DimAutoStyle. Reordered DimAutoStyle.
Fixes gui-cs#3469, gui-cs#3473, gui-cs#3482 - `Dim.Auto` fixes and `Pos`/`Dim` refactor to support TGD
… for MessageBox/Dialog. Messagebox and Dialog now use Pos.Align and Dim.Auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Todo
Margin
to have a "Shadow" Style - When enabled draws the correct half-height block glyphs in the right placesButton
to useMargin.EnableShadow
Button
with shadow work reliably and automatically.EnableShadow
on other Views where it may make sense visually.Background
When I created Frames (now Adornments) i had a vision that
Margin
could be used to enable the 3D effect that we had mostly working in v1, but got negated with all the changes to v2.I had a shower thought recently on this and decided to quickly code a prototype up to see if my instincts were right.
This PR demonstrates that I was. The concept is leveraging Margin like this:
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)