Fixes #3374 - Curses and Net drivers don't generate click events unless mouse has not moved

[tig]

Fixes

• Fixes Not always getting Button1Clicked events on Netdriver or CursesDriver #3374

Proposed Changes/Todos

• Add debug spew to further diagnose
• ???

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tig]

@BDisp - I suspect you have more knowledge of this than I. Do you have any suggestions on how to address this?

[BDisp]

The clicked event is only generated if the mouse location is the same on the buttonPressed and buttonReleased. This is the normal behavior of the clicked event. If you press the mouse button and move the mouse keeping the button pressed, when you release the button the location isn't the same and thus the clicked event isn't processed.

This allows a user cancel a click event if the button was pressed and then regret do it and move the mouse to another place and release it avoiding a clicked event.

[tig]

The clicked event is only generated if the mouse location is the same on the buttonPressed and buttonReleased. This is the normal behavior of the clicked event. If you press the mouse button and move the mouse keeping the button pressed, when you release the button the location isn't the same and thus the clicked event isn't processed.

This allows a user cancel a click event if the button was pressed and then regret do it and move the mouse to another place and release it avoiding a clicked event.

I'm not sure I love the logic you've described. It means that the user has to hold the mouse perfectly still to cause a clicked event.

However, we can debate that another day.

Please try the steps I outlined in #3374 - You'll see that even though the mouse is perfectly still, pressing the button and releasing it does not cause either driver to receive a clicked event.

[BDisp]

Please try the steps I outlined in #3374 - You'll see that even though the mouse is perfectly still, pressing the button and releasing it does not cause either driver to receive a clicked event.

The bug is in this line. The point isn't assigned if it isn't null. In that line point must always be equal to pos.

Terminal.Gui/Terminal.Gui/ConsoleDrivers/EscSeqUtils/EscSeqUtils.cs

Line 778 in 43e4a83

point ??= pos;

To fix change to:

point = pos;

[BDisp]

I'm not sure I love the logic you've described. It means that the user has to hold the mouse perfectly still to cause a clicked event.

However, we can debate that another day.

I hope you consider this because many app use that behavior and prevents many times when accidently press a button and avoiding the clicked after moving the mouse. If a user want to catch all the clicks he can use the ButtonPressed event.

[tig]

I'm not sure I love the logic you've described. It means that the user has to hold the mouse perfectly still to cause a clicked event.
However, we can debate that another day.

I hope you consider this because many app use that behavior and prevents many times when accidently press a button and avoiding the clicked after moving the mouse. If a user want to catch all the clicks he can use the ButtonPressed event.

Lets discuss this here:

• Fixes #3370. Adds visual highlight for press and hold (for Button, Checkbox, RadioGroup, and Border) #3372