Fixes #3368. Fix unit tests to dispose properly #3369
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
View
correctly. #3368Proposed Changes/Todos
Application.Top?.Dispose
inAutoInitShutdown.After
. This will cause several dozen unit tests to fail. The fix for most of them is to simply add atop.Dispose ()
as the last line of the test.SetupFakeDriver
to inherit fromTestRespondersDisposed
(and ensureBefore/After
callbase
). This will cause even more existing unit tests to fail. Here, the fixes will involve just disposingView
objects the tests create but don't dispose.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)