Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3368. Fix unit tests to dispose properly #3369

Draft
wants to merge 4 commits into
base: v2_develop
Choose a base branch
from

Conversation

tig
Copy link
Collaborator

@tig tig commented Apr 1, 2024

Fixes

Proposed Changes/Todos

  • Update API docs and conceptual documentation
  • Remove the call to Application.Top?.Dispose in AutoInitShutdown.After. This will cause several dozen unit tests to fail. The fix for most of them is to simply add a top.Dispose () as the last line of the test.
  • Change SetupFakeDriver to inherit from TestRespondersDisposed (and ensure Before/After call base). This will cause even more existing unit tests to fail. Here, the fixes will involve just disposing View objects the tests create but don't dispose.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig marked this pull request as draft April 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant