Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3073: Adds Bar as a replacement for StatusBar #3076

Draft
wants to merge 55 commits into
base: v2_develop
Choose a base branch
from

Conversation

tig
Copy link
Collaborator

@tig tig commented Dec 23, 2023

Fixes

Todos

Still very much a Proof of Concept/Prototype

  • Implement Shortcut view that holds a Key, KeyBindingScope, Title, and help Text.
    • Renders just like a MenuItem.
      • Proper spacing/alignment of help text.
    • Supports arbitrary Views in the CommandView (first) position. E.g. CheckBox
    • Works with KeyBindingScope.Application and KeyBindingScope.HotKey.
    • Supports mouse clicks to activate the shortcut
  • Implement Bar view that
    • Looks just like the old StatusBar (StatusBarStyle = true, Orientation.Horizontal)
    • Looks just like the old MenuBar (StatusBarStyle = false, Orientation.Horizontal)
    • Looks just like the old Menu (StatusBarStyle = false, Orientation.Vertcal)
  • Update UI Catalog to use the new Bar
  • Replace Toplevel.StatusBar

DATQ7MI 1

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #3037: Add's Bar as a replacement for StatusBar Fixes #3073: Add's Bar as a replacement for StatusBar Dec 26, 2023
@tig tig changed the title Fixes #3073: Add's Bar as a replacement for StatusBar Fixes #3073: Adds Bar as a replacement for StatusBar Dec 26, 2023
tig and others added 27 commits January 9, 2024 14:52
@tig tig mentioned this pull request Jan 19, 2024
@tig tig mentioned this pull request Feb 18, 2024
26 tasks
@tig tig mentioned this pull request Apr 12, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant