Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 11 assertion from project settings #27158

Merged
merged 1 commit into from
May 17, 2024

Conversation

ioannakok
Copy link
Contributor

What does this change?

Remove Java 11 assertion from project settings

Why?

This is not necessary. We pass -release:11 in Scala options so the Scala compiler is already going to enforce that Java 11 is the minimum supported version. Because of this PR: guardian/scala-steward-public-repos#67 running Scala steward for frontend was failing due to this assertion because Scala Steward is running with Java 21.

@ioannakok ioannakok requested a review from a team as a code owner May 17, 2024 11:18
This is not necessary. We pass `-release:11` in Scala options so the Scala compiler is already going to enforce that Java 11 is the minimum supported version. Because of this PR: guardian/scala-steward-public-repos#67 running Scala steward for frontend was failing due to this assertion because Scala Steward is running with Java 21.

Co-authored-by: Roberto Tyley <[email protected]>
Comment on lines -36 to -42
initialize := {
val _ = initialize.value
assert(
sys.props("java.specification.version") == "11",
"Java 11 is required for this project.",
)
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I regret writing this code so long ago!

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 1 hour, 13 minutes and 52 seconds ago)

ioannakok added a commit that referenced this pull request May 17, 2024
It was removed in #27158 but I messed up when resolving conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants