Remove Java 11 assertion from project settings #27158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not necessary. We pass `-release:11` in Scala options so the Scala compiler is already going to enforce that Java 11 is the minimum supported version. Because of this PR: guardian/scala-steward-public-repos#67 running Scala steward for frontend was failing due to this assertion because Scala Steward is running with Java 21. Co-authored-by: Roberto Tyley <[email protected]>
ioannakok
force-pushed
the
remove-java-11-assertion
branch
from
e069616
to
779048f
Compare
rtyley
approved these changes
May 17, 2024
Comment on lines
-36
to
-42
| initialize := { | ||
| val _ = initialize.value | ||
| assert( | ||
| sys.props("java.specification.version") == "11", | ||
| "Java 11 is required for this project.", | ||
| ) | ||
| }, |
There was a problem hiding this comment.
Ah, I regret writing this code so long ago!
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 1 hour, 13 minutes and 52 seconds ago)
|
ioannakok
added a commit
that referenced
this pull request
May 17, 2024
It was removed in #27158 but I messed up when resolving conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove Java 11 assertion from project settings
Why?
This is not necessary. We pass
-release:11in Scala options so the Scala compiler is already going to enforce that Java 11 is the minimum supported version. Because of this PR: guardian/scala-steward-public-repos#67 running Scala steward for frontend was failing due to this assertion because Scala Steward is running with Java 21.