Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not lookup pressed fronts in S3 if front does not exist #27152

Merged
merged 2 commits into from
May 21, 2024
Merged

Do not lookup pressed fronts in S3 if front does not exist #27152

merged 2 commits into from
May 21, 2024

Conversation

georgeblahblah
Copy link
Contributor

What does this change?

  • checks whether a front id exists in the fronts config before trying to fetch the pressed json from S3

Why?

  • these log messages can be confusing, especially during incident investigation. There is no need to try to access a key from S3 that we know does not exist.

@georgeblahblah georgeblahblah marked this pull request as ready for review May 20, 2024 14:46
@georgeblahblah georgeblahblah requested a review from a team as a code owner May 20, 2024 14:46
ioannakok
ioannakok approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@ioannakok ioannakok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@github-actions GitHub Actions
Copy link
Contributor

Deploy build 1934 of dotcom:frontend-all to CODE

All deployment options

From guardian/actions-riff-raff.

@georgeblahblah georgeblahblah merged commit 72752c8 into main May 21, 2024
3 checks passed
@georgeblahblah georgeblahblah deleted the s3-lookup-fix branch May 21, 2024 09:17
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @georgeblahblah 15 minutes and 4 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannakok ioannakok ioannakok approved these changes

@abeddow91 abeddow91 abeddow91 approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georgeblahblah @prout-bot @ioannakok @abeddow91