CCover

[b00tkitism]

No description provided.

[yukani]

Note for future: We're usually reversing per-class basis. If you want to reverse all of CCover methods, open a CCover PR with all reversed functions committed.

[Pirulax]

It's fine I do functions only time to time too.
But yeah, CCover seems easy, you could try reversing the rest of it too.

[b00tkitism]

btw the codes that I wrote are not clean, I'll reverse whole CCover and then make the code more cleaner.

[Pirulax]

CVector CCover::FindVectorFromFirstToMissingVertex(CColTriangle *tri, uint32 *sharedVert, CVector *vertices)

[temajm]

Suggested change

	vector.x = (float)sin(direction * 0.02454369);
	vector.y = (float)cos(direction * 0.02454369);
	vector.z = 0.0;
	vector.x = -sinf(direction * 0.02454369f);
	vector.y = cosf(direction * 0.02454369f);
	vector.z = 0.0f;

How do you like the idea of ​​adding the following functions to common.h and using them?:

constexpr inline uint8_t CompressRad(float rad) { return (uint8)(rad * (128.0f / PI)); }
constexpr inline float DecompressRad(uint8 rad) { return (float)rad * (PI / 128.0f); }

Then it can be implemented like this:

    return CVector{
        -std::sinf(DecompressRad(direction)),
        std::cosf(DecompressRad(direction)),
        0.0f
    };

[yukani]

How do you like the idea of ​​adding the following functions to common.h and using them?

FixedFloat<uint8, 128.0f / PI> can be used for this purpose

[Pirulax]

We could also typedef it for this purpose.
using FixedRadians = FixedFloat<uint8, 128.0f / PI>

[Pirulax]

that's kinda errnous tho, it should be 255 / PI... Though seemingly they did use 256 instead, which might've lead to overflows... :D

PR scope changed