-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdk connection api endpoint #2542
base: main
Are you sure you want to change the base?
Conversation
Deploy preview for docs ready! ✅ Preview Built with commit 16ad6b6. |
Your preview environment pr-2542-bttf has been deployed. Preview environment endpoints are available at: |
packages/back-end/src/api/openapi/payload-schemas/PostSdkConnectionPayload.yaml
Outdated
Show resolved
Hide resolved
552104b
to
c5b67bd
Compare
d498994
to
c757177
Compare
|
||
const capabilityParams = [ | ||
["encryption", "encryptPayload"], | ||
["remoteEval", "remoteEvalEnabled"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add visualEditor
and redirects
.
type CababilitiesParams = { [k in CababilitiesParamKey]?: boolean }; | ||
|
||
const premiumFeatures = [ | ||
["encrypt-features-endpoint", "encryptPayload"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add visual-editor
, hash-secure-attributes
, remote-evaluation
, and redirects
.
In addition, if the user doesn't have cloud-proxy
and IS_CLOUD, then they shouldn't be able to specify any of the proxy settings.
if (payload[param] && !capabilities.includes(capability)) | ||
throw new Error( | ||
`SDK version ${sdkVersion} doesn not support ${capability}` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should differentiate between the version not supporting this feature and the language not supporting it. Basically, check the capabilities of the latest version and then you can say "This isn't supported by this language" vs "You need to update your version"
No description provided.