Grant first user on a new installation super admin access #2520
Conversation
|
Your preview environment pr-2520-bttf has been deployed. Preview environment endpoints are available at: |
| @@ -276,7 +276,9 @@ export async function postFirstTimeRegister( | |||
| }); | |||
| } | |||
|
|
|||
| const user = await createUser(name, email, password); | |||
| // grant the first user on a new installation super admin access | |||
| const user = await createUser({ name, email, password, superAdmin: true }); | |||
There was a problem hiding this comment.
Digging into this endpoint more, isNewInstallation uses an in-memory cache, so it's possible in a horizontally scaled environment it could return true when there are actually already orgs/users.
Looking through the code, I don't think that in-memory cache is valuable. isNewInstallation is not called that often and it's only doing 2 efficient mongo lookups.
So, I'd recommend removing the caching layer to reduce the chance of bugs here and elsewhere.
There was a problem hiding this comment.
Removed the caching layer from isNewInstallation and the use of markInstalled entirely since the former method will check every time.
RE: Thread on a previous PR, we want to grant the first user to be created on a new installation with super admin access.
Changes
createUsermethod to take single object argumentsuperAdminproperty, defaults tofalse/auth/firsttimeendpointQuestions
/auth/signupendpoint but reverted since it seemed like an impossible scenario. Could use confirmation on this and any add'l insights on what could have been missed.