plugin suggest: add missing NULL check for grn_ctx_at() #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested changes
Oct 10, 2017
| @@ -657,10 +657,22 @@ learner_init_columns(grn_ctx *ctx, grn_suggest_learner *learner) | |||
| grn_obj *seqs, *events, *post_item, *items, *pairs; | |||
|
|
|||
| learner->seqs = seqs = grn_ctx_at(ctx, GRN_OBJ_GET_DOMAIN(learner->seq)); | |||
| if (!learner->seqs) { | |||
| ERR(GRN_DOMAIN_ERROR, | |||
There was a problem hiding this comment.
Why GRN_DOMAIN_ERROR?
It's based on EDOM:
EDOM Mathematics argument out of domain of function (POSIX.1, C99).
| learner->seqs_events = grn_obj_column(ctx, seqs, CONST_STR_LEN("events")); | ||
|
|
||
| events_id = grn_obj_get_range(ctx, learner->seqs_events); | ||
| learner->events = events = grn_ctx_at(ctx, events_id); | ||
| if (!learner->events) { | ||
| ERR(GRN_UNKNOWN_ERROR, | ||
| "failed to initialize columns because event id: <%d> is not found.", |
There was a problem hiding this comment.
: <...> should be placed at the last. We should not put it the middle of sentence.
"failed to refer sequence's event table: <%.*s>: <%u>(<%.*s>)", seqs_events_name_size, seqs_events_name, events_id, events_name_size, events_name)"
events_name will be able to get by grn_table_get_key() against grn_ctx_db().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.