Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-Month Change Log #3510

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

beahackman
Copy link
Collaborator

@beahackman beahackman commented Aug 17, 2023

Deploy Preview

What does this PR do?

This PR adds a 3 month change log to the bottom of each guidance by extending the fetch to 100 PR's.

Where should the reviewer start?

app.js to see the fetch logic, and then move into the Layout.js to access the InPageChangeLog component.

What testing has been done on this PR?

Tested it with cases regarding the 30 days time limit vs. 3 month. Also checked the light/dark mode and re-sizing capabilities.

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Adding PR's within the three month span, leaving guidances and returning (ensuring that it isn't affected by visitation tracking.)

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Screenshot 2023-08-17 at 3 23 49 PM

Should this PR be mentioned in Design System updates?

Yes

Is this change backwards compatible or is it a breaking change?

@netlify
Copy link

netlify bot commented Aug 17, 2023

👷 Deploy request for keen-mayer-a86c8b pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a94ab30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant