Update filtering.mdx #3495
Open
Update filtering.mdx #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the terminating emphasis double "**" were missing and messed up the formatting of the Guidelines section.
MikeKingdom
reviewed
Aug 2, 2023
| - **Is the user going to be selecting from 4 or fewer multiple selection options?** Filter with | ||
| [CheckBoxGroup](#filters-in-a-center-layer). | ||
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from, use [SelectMultiple](/components/SelectMultiple). | ||
| - **When the data contains 10 or more items, consider including search in your [SelectMultiple](/components/SelectMultiple) implementation. | ||
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from?** Use [SelectMultiple](/components/SelectMultiple). |
There was a problem hiding this comment.
Why add the question mark? It's not exactly a question
MikeKingdom
reviewed
Aug 2, 2023
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from, use [SelectMultiple](/components/SelectMultiple). | ||
| - **When the data contains 10 or more items, consider including search in your [SelectMultiple](/components/SelectMultiple) implementation. | ||
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from?** Use [SelectMultiple](/components/SelectMultiple). | ||
| - When the data contains 10 or more items, consider including search in your [SelectMultiple](/components/SelectMultiple) implementation. |
There was a problem hiding this comment.
Seems like this line still needs the ** as does line 94. At least it looks odd compared to the others
Fixed the wording to be consistent across the bullet points. Added emphasis to keep them all looking the same.
taysea
reviewed
Sep 5, 2023
| - **Is the user going to be selecting from 4 or fewer multiple selection options?** Filter with | ||
| [CheckBoxGroup](#filters-in-a-center-layer). | ||
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from, use [SelectMultiple](/components/SelectMultiple). | ||
| - **When the data contains 10 or more items, consider including search in your [SelectMultiple](/components/SelectMultiple) implementation. | ||
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from?** Use [SelectMultiple](/components/SelectMultiple). |
There was a problem hiding this comment.
Suggested change
| - **If the filter set allows for multiple selections and there are 5 or more items to choose from?** Use [SelectMultiple](/components/SelectMultiple). | |
| - **Does the filter set allow for multiple selections and are there 5 or more items to choose from?** Use [SelectMultiple](/components/SelectMultiple). |
Maybe this is better wording @MikeKingdom ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the terminating markdown emphasis "**" chars were missing and messed up the formatting when rendering the Guidelines section.
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?