Update Google analytics to support google tag manager and GA4 #3469
+277
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successful deploy here: https://app.netlify.com/sites/keen-mayer-a86c8b/deploys/64ac425521410d177485ae71 |
|
Seems like "nonce" approach doesn't work for static site builds (which is what our site is). Wondering if we move forward as is since we're only collecting page views just to see if the pipeline is working? Can adjust the CSP as necessary following. |
MikeKingdom
reviewed
Jul 10, 2023
Comment on lines
+11
to
+24
| export const pageview = url => { | ||
| window.gtag('config', GA_TRACKING_ID, { | ||
| page_path: url, | ||
| }); | ||
| }; | ||
|
|
||
| // https://developers.google.com/analytics/devguides/collection/gtagjs/events | ||
| export const event = ({ action, category, label, value }) => { | ||
| window.gtag('event', action, { | ||
| event_category: category, | ||
| event_label: label, | ||
| value, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Instead of hard coding calls to these inside _app.js and such you could simply look at the event in line 5 above (in the analytics callback) and send the appropriate ga event there. That's what that callback is intended for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
What does this PR do?
Adds support for google tag manager, GA4 to collect page views on Design System site.
Key changes:
Resources for CSP changes: https://developers.google.com/tag-platform/tag-manager/csp#google_analytics_4_google_analytics
Where should the reviewer start?
aries-site/src/pages/_app.js
What testing has been done on this PR?
The script is being loaded successfully (checked Network tab). Need to merge to see if the data is flowing properly.
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Closes #3444
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?