Adds type of onChange to RangeInput #6974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
approved these changes
Oct 19, 2023
jcfilben
added
PRty
jcfilben
reviewed
Nov 9, 2023
| Omit<JSX.IntrinsicElements['input'], 'color' | 'step' | 'value'> {} | ||
| Omit< | ||
| JSX.IntrinsicElements['input'], | ||
| 'color' | 'step' | 'value' | 'onChange' |
There was a problem hiding this comment.
What is the difference between the default onChange that is passed though the intrinsic element and the onChange type defined on line 19?
jcfilben
added
waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves event handler type for RangeInput component.
What does this PR do?
Improves event handler type for RageInput component.
Where should the reviewer start?
index.d.ts of RangeInput
What testing has been done on this PR?
Checked the types locally
How should this be manually tested?
Verify the typing
Do Jest tests follow these best practices?
Not applicable
Any background context you want to provide?
What are the relevant issues?
#3165
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
May be breaking for people using typescript. Because we are now making the type stricter.