Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for internet explorer #6938

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

eliasecasta
Copy link

@eliasecasta eliasecasta commented Sep 6, 2023

What does this PR do?

Removes no longer needed code to support internet explorer browser for the dropdown menus.

This PR potentially fixes Issue #6879

Where should the reviewer start?

src\js\components\Drop\StyledDrop.js

What testing has been done on this PR?

I was able to test the impact in chrome and firefox, I dont have a mac so I was unable to test it on Safari.

How should this be manually tested?

Adding extra text to the dropdown elements to check for text overflow.

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Chrome code disabled:

chrome code disabled

Edge code disabled:

edge code disabled

Edge code enabled:

edge code enabled

Firefox code disabled:

firefox code disabled

Do the grommet docs need to be updated?

No.

Should this PR be mentioned in the release notes?

No.

Is this change backwards compatible or is it a breaking change?

Backwards compatible.

@jcfilben
Copy link
Collaborator

jcfilben commented Sep 9, 2023

Some of the jest snapshots need updated to reflect this change. You can update the snapshots by running yarn jest -u

@jcfilben jcfilben added the waiting Awaiting response to latest comments label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Awaiting response to latest comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants