Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessibility violations in List Storybook #6861

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix accessibility violations in List Storybook #6861

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f761b3d
Fix accessibility issue in list
navedqb Jul 4, 2023
6eac55d
Fix accessibility violations
navedqb Jul 4, 2023
6c64a48
Merge pull request #1 from navedqb/6124--fix-accessibility-issue-for-…
navedqb Jul 4, 2023
9a49a65
Revert changes.
navedqb Jul 5, 2023
a46aedb
Revert changes.
navedqb Jul 5, 2023
fe4e91a
Fix accessibility violations in List storybook.
navedqb Jul 5, 2023
5f10a7f
Merge branch 'master' into 6124--fix-accessibility-issue-for-list
navedqb Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/js/components/List/stories/Order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ export const Order = () => {
const [ordered, setOrder] = useState(locations);
return (
<Box align="center" pad="large">
<List aria-label="order list" data={ordered} onOrder={setOrder} />
<List
role="list"
aria-label="order list"
data={ordered}
onOrder={setOrder}
/>
</Box>
);
};
Expand Down
1 change: 1 addition & 0 deletions src/js/components/List/stories/Pinned.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const Pinned = () => {
return (
<Box align="center" pad="large">
<List
role="list"
aria-label="pinned list"
data={ordered}
onOrder={setOrder}
Expand Down