Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database documentations #937

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Database documentations #937

wants to merge 11 commits into from

Conversation

fflorent
Copy link
Collaborator

@fflorent fflorent commented Apr 15, 2024

This is an attempt to document the databases (home and grist documents).

I focus more on the home database for now, the documentation of the tables in documentation should be done in a future work.

To view the documentation rendered: https://github.com/fflorent/grist-core/blob/db-doc/documentation/database.md

@fflorent fflorent marked this pull request as ready for review April 29, 2024 17:23
@fflorent fflorent force-pushed the db-doc branch 3 times, most recently from d38f2d8 to 584a896 Compare April 29, 2024 17:29
The migrations are handled in the python sandbox in this code:
https://github.com/gristlabs/grist-core/blob/main/sandbox/grist/migrations.py

For more information, please consult [the documentation for migrations](./migrations.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add information of sandbox/grist/schema.py that are the schema of a Doc Database and when we create a new migration we have to adapt this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to ./migrations.md gives a indirect reference to this file with more context. What do you think?

`viewers`, `members` and `guests` have basically the same rights (like viewers), the only difference between them is that:
- `viewers` are explicitly allowed to view the resource and its descendants;
- `members` are specific to the organisations and are meant to allow access to be granted to individual documents or workspaces, rather than the full team site.
- `guests` are (FIXME: help please on this one :))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe (not sure !!) that are mail adresses that we add in ACL but which have never logged in and therefore don't have an account. But I don't see it in the choices in frontend

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like they are meant for people invited to workspaces or documents, indeed, but:

  • these people are directly granted the role they were assigned (not the guest role);
  • for the ancestor resources (workspaces and/or orgs), they are assigned a guest role;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it understandable more quickly maybe but the arrow between Org1 Owners and Ws1 Owners in dotted line and if it's possible put an bug red cross on all the Ws1 Owners ? And like that maybe the new indication won't be necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the 'new' label would still be necessary, but I agree that the dotted line is clearer, I added that.

Copy link
Collaborator

@CamilleLegeron CamilleLegeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it's very nice to have this documentation, I put some remarks

@jordigh jordigh self-assigned this Apr 30, 2024
Copy link
Contributor

@jordigh jordigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only offering some basic proofreading. I cannot go right now into the details of the description of the schema.

documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
documentation/database.md Outdated Show resolved Hide resolved
| name | The name as displayed in the UI |
| domain | The part that should be added in the URL |
| owner | The id of the user who owns the org |
| host | ??? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it's this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But still unclear to me, considering the domain column.

@fflorent fflorent requested a review from hexaltation May 23, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants