Add Delete Function to Vector Store Drivers #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
collindutter
requested changes
Dec 28, 2023
Add Delete Function to All Classes That Inherit from the Base Vectorstore Class Add Delete Function to Base Vectorstore Class Implement Delete Function for MongoDB Vectorstore Implement Delete Collection Function for MongoDB Vectorstore Add Test for Delete Function for MongoDB Vectorstore
To ensure, that delete_collection works as expected, the test was adjusted to guarantee that the behaviour is tested correctly.
collindutter
requested changes
Jan 2, 2024
Rename delete to delete_vector Remove google from poetry dependencies Remove pyright from poetry dev dependencies
collindutter
changed the title
|
@bjorger FYI don't worry about the |
collindutter
requested changes
Jan 3, 2024
Add return type to abstract delete_vector method Remove new line from pyproject.toml
collindutter
previously approved these changes
Jan 3, 2024
vasinov
previously requested changes
Jan 3, 2024
Remove delete_collection test
collindutter
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #530
Add Delete Function to All Classes That Inherit from the Base Vectorstore Class
Add Delete Function to Base Vectorstore Class
Implement Delete Function for MongoDB Vectorstore
Implement Delete Collection Function for MongoDB Vectorstore
Add Test for Delete Function for MongoDB Vectorstore