Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to hide destinations from the picker context menu. #498

Open
wants to merge 1 commit into
base: release/1.3
Choose a base branch
from

Conversation

KieranDevvs
Copy link

This pull request adds the concept of hidden destinations. If a destination is hidden then the type is still loaded into the DI container (to be able to manage and unhide the plugin) but it will not be shown as an option for the user to interact with. This functionally lets you hide options you have no intention of using, while still letting the user manage the options via the UI rather than having to find the config file in %appdata% and configure the ini file themselves.

I initially planned for this feature to use the excludedDestinations feature however, when attempting to implement it, I found out that if the destination is excluded then its not loaded into the DI system and thus cannot be managed at runtime (to unexclude it).

Thus the introduction of a 3rd state:

  • Hidden
    • The destination is loaded at runtime but is hidden from most user interactivity
  • Excluded
    • The destination is not loaded at runtime
  • Active
    • The destination is functional

image
image
image

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants