Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar item and menu item for copy and close in one click. #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bholliger
Copy link

Solution for Feature Request #268
#268

Signed-off-by: Bruno Holliger [email protected]

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021

CLA assistant check
All committers have signed the CLA.

@Lakritzator
Copy link
Member

This is cool, we have many discussions about the wish that the whole capture is copied with "Ctrl+C", but we have an editor with elements so that doesn't make sense. This feature doesn't force us a shortcut key, it's simple so might make sense to include.

I am hesitant to include it just like this, as we do not have translations for all the languages, so these will fallback to english. This is not the experience I'd like. But I was thinking about if my language functionality supports requesting if there is a translation, if not we do not add the menu item. This would mean that only people who use a language for which a translation for the menu item is available, would see it. I think this is fair, I need to check this from a technical perspective.

Btw. why not just translate? Well we have way over 20 translations, contacting all of the people who once did a translation is not a simple task, for some we do not even have a contact. So we try to prevent adding new items to the UI which need translations until we have a better process in place.

@bholliger
Copy link
Author

Thanks for your feedback. I totally understand this. I just created it for myself. Instead of letting it rot on my disk, I did a pull request.
I have seen others use https://crowdin.com/
I'm not sure about the costs.

@fabiochelly
Copy link

fabiochelly commented Jul 27, 2022

The best would be to use ESC for that: copy the current image then quit. It would be a huge improvement. For now, I'm using SnagIt because it allows less manipulations to just add ellipse and copy and quit. But greenshot is a lot lighter. It's too bad we need so many shortcuts to just make a copy/paste

@Lakritzator
Copy link
Member

@fabiochelly one of the challenges of building a tool, is to have as little "special" cases as possible. That sometimes means it has trade-offs, someone might really "badly" want one thing, others wouldn't use it.

ESC is already used to cancel a drawing mode, so we cannot just add this because a lot of people would press one time to many and the editor closes. It's also not common practice to close an editor window with ESC. This doesn't mean that this is not possible, it just needs a lot of thought.

You might say, add it as an option, which complicates the application with so many settings. We in fact have no UI for quite a lot of possible settings... just because they are not always worth confusing the users (and we also need to have "space" on the settings screen, and provide translations in many languages)

You already said "Greenshot is a lot lighter", that is exactly the fact.

I currently have more pressing matters, so sorry that I cannot come to an end on this topic, but I do this all in my limited free time.

@fabiochelly
Copy link

fabiochelly commented Jul 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants