[MAINTENANCE] performance, avoid HTTP round trips #9929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
commented
May 15, 2024
|
|
||
| @override | ||
| @staticmethod | ||
| def gx_cloud_response_json_to_object_collection( |
There was a problem hiding this comment.
see great_expectations/data_context/store/datasource_store.py for reference implementation
Kilo59
reviewed
May 15, 2024
There was a problem hiding this comment.
Nice work! It's hard to overstate the impact this will have 😄
Approach seems reasonable I would suggest using the _fake_web_api mock to assert that the expected number of calls are being made to /expectations-suites + /expectations-suites?name=<SUITE-NAME>
I think you'll need to take the PR off of draft mode to run the integration tests.
Kilo59
reviewed
May 21, 2024
| ) | ||
|
|
||
| checkpoint.run() | ||
| # TODO assert GET expectation-suites called |
There was a problem hiding this comment.
Did you mean to do this?
I'm working on this right now.
There was a problem hiding this comment.
This is turning out to be much more of a pain to setup than I expected.
Let's do this as a followup.
tyler-hoffman
approved these changes
May 22, 2024
Kilo59
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_allmethod on the ExpectationsStore's interface.