Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Set application query param for SnowflakeDatasource (#9863) #9925

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

roblim
Copy link
Member

@roblim roblim commented May 14, 2024

Pulling in recent change to 0.18.x - see #9863

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

# Conflicts:
#	docs/docusaurus/versioned_docs/version-0.18/snippets/redshift_python_example.py
#	great_expectations/datasource/fluent/snowflake_datasource.py
@roblim roblim self-assigned this May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit a7bc7bb
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6646f2f89b39f90008e06a95
😎 Deploy Preview https://deploy-preview-9925.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.42%. Comparing base (b7c4291) to head (a7bc7bb).

Files Patch % Lines
...ctations/datasource/fluent/snowflake_datasource.py 42.85% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9925       +/-   ##
============================================
- Coverage    77.83%   64.42%   -13.41%     
============================================
  Files          454      452        -2     
  Lines        39533    39541        +8     
============================================
- Hits         30771    25475     -5296     
- Misses        8762    14066     +5304     
Flag Coverage Δ
3.10 64.42% <55.55%> (-0.01%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.42% <55.55%> (-0.01%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.8 64.44% <55.55%> (-0.01%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.8 aws_deps ?
3.8 big ?
3.8 databricks ?
3.8 filesystem ?
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 64.44% <55.55%> (-0.01%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roblim roblim requested a review from cdkini May 14, 2024 07:10
@roblim roblim marked this pull request as ready for review May 14, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants