Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Migrate ci to enterprise-arc runners #9757

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

nicgrayson
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 34faefb
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66589189538dcd00085916d4

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (1b03927) to head (34faefb).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9757      +/-   ##
===========================================
+ Coverage    79.13%   79.24%   +0.11%     
===========================================
  Files          454      454              
  Lines        38574    38763     +189     
===========================================
+ Hits         30524    30717     +193     
+ Misses        8050     8046       -4     
Flag Coverage Δ
3.10 65.57% <ø> (+0.18%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.57% <ø> (+0.18%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.16% <ø> (-0.01%) ⬇️
3.11 aws_deps 45.34% <ø> (+<0.01%) ⬆️
3.11 big 54.24% <ø> (-0.05%) ⬇️
3.11 databricks 46.47% <ø> (+0.01%) ⬆️
3.11 filesystem 60.08% <ø> (-0.03%) ⬇️
3.11 mssql 49.51% <ø> (-0.02%) ⬇️
3.11 mysql 49.57% <ø> (-0.02%) ⬇️
3.11 postgresql 53.81% <ø> (-0.02%) ⬇️
3.11 snowflake 47.15% <ø> (+0.01%) ⬆️
3.11 spark 57.09% <ø> (-0.03%) ⬇️
3.11 trino 51.67% <ø> (-0.02%) ⬇️
3.8 65.58% <ø> (+0.16%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.16% <ø> (-0.01%) ⬇️
3.8 aws_deps 45.36% <ø> (+<0.01%) ⬆️
3.8 big 54.26% <ø> (-0.05%) ⬇️
3.8 databricks 46.49% <ø> (+0.01%) ⬆️
3.8 filesystem 60.09% <ø> (-0.03%) ⬇️
3.8 mssql 49.49% <ø> (-0.02%) ⬇️
3.8 mysql 49.55% <ø> (-0.02%) ⬇️
3.8 postgresql 53.79% <ø> (-0.02%) ⬇️
3.8 snowflake 47.17% <ø> (+<0.01%) ⬆️
3.8 spark 57.05% <ø> (-0.03%) ⬇️
3.8 trino 51.65% <ø> (-0.02%) ⬇️
3.9 65.57% <ø> (+0.16%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 48.36% <ø> (+0.06%) ⬆️
docs-creds-needed 49.44% <ø> (-0.02%) ⬇️
docs-spark 48.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicgrayson nicgrayson requested a review from billdirks May 29, 2024 20:41
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question about the xdist number of workers.

@@ -1042,7 +1042,7 @@ def ci_tests( # noqa: C901 - too complex (9)
pytest_options = [f"--durations={slowest}", "-rEf"]

if xdist:
pytest_options.append("-n auto")
pytest_options.append("-n 4")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to hard code this to 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on purpose. Kubernetes exposes all cores of the host machine to the pod even if the pod is allocated fewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants