-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Migrate ci to enterprise-arc runners #9757
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9757 +/- ##
===========================================
+ Coverage 79.13% 79.24% +0.11%
===========================================
Files 454 454
Lines 38574 38763 +189
===========================================
+ Hits 30524 30717 +193
+ Misses 8050 8046 -4 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b30c819
to
f6f7f78
Compare
f6f7f78
to
de02bf4
Compare
…ctations/great_expectations into m/migrate-gha-workers * 'm/migrate-gha-workers' of https://github.com/great-expectations/great_expectations: [DOCS] Learn TOC Updates (#9784)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One question about the xdist number of workers.
@@ -1042,7 +1042,7 @@ def ci_tests( # noqa: C901 - too complex (9) | |||
pytest_options = [f"--durations={slowest}", "-rEf"] | |||
|
|||
if xdist: | |||
pytest_options.append("-n auto") | |||
pytest_options.append("-n 4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to hard code this to 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was on purpose. Kubernetes exposes all cores of the host machine to the pod even if the pod is allocated fewer
No description provided.